Skip to content

Allow for proposed new parsing of array[end] in Setfield #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Allow for proposed new parsing of array[end] in Setfield #182

merged 1 commit into from
Feb 21, 2025

Conversation

mlechu
Copy link
Contributor

@mlechu mlechu commented Feb 18, 2025

This is essentially the same change as JuliaObjects/Accessors.jl#196. Description copied below:

To fix JuliaLang/julia#57269, a small-but-breaking AST change is needed (PR JuliaLang/julia#57368). The set macro in Setfield and Accessors breaks, and enough packages depend on this macro that it needs to be updated before deciding whether to merge the julialang PR.

This PR only recognizes the new way of parsing array[end], and should not change any behaviour when used with the current parser.

@jw3126
Copy link
Owner

jw3126 commented Feb 19, 2025

JuliaObjects/Accessors.jl#196

@topolarity
Copy link

The Accessors change has now merged - Anything else needed here @jw3126 ?

@jw3126 jw3126 merged commit 81d8dab into jw3126:master Feb 21, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arr[var"end"] is the same as arr[end]
3 participants
@mlechu @jw3126 @topolarity